Removed offset item decoration to fix empty space bug

app/src/main/java/com/sirekanyan/knigopis/common/android/recycler/BottomOffsetItemDecoration.kt

@@ -1,25 +0,0 @@
-package com.sirekanyan.knigopis.common.android.recycler
-
-import android.content.Context
-import android.graphics.Rect
-import android.view.View
-import androidx.recyclerview.widget.RecyclerView
-import com.sirekanyan.knigopis.R
-
-class BottomOffsetItemDecoration(context: Context) : RecyclerView.ItemDecoration() {
-
-    private val offset = context.resources.getDimensionPixelSize(R.dimen.bottom_navigation_height)
-
-    override fun getItemOffsets(
-        outRect: Rect,
-        view: View,
-        parent: RecyclerView,
-        state: RecyclerView.State
-    ) {
-        val itemPosition = parent.getChildAdapterPosition(view)
-        if (itemPosition == state.itemCount - 1) {
-            outRect.bottom = offset
-        }
-    }
-
-}

app/src/main/java/com/sirekanyan/knigopis/common/android/recycler/TopOffsetItemDecoration.kt

@@ -1,25 +0,0 @@
-package com.sirekanyan.knigopis.common.android.recycler
-
-import android.content.Context
-import android.graphics.Rect
-import android.view.View
-import androidx.recyclerview.widget.RecyclerView
-import com.sirekanyan.knigopis.R
-
-class TopOffsetItemDecoration(context: Context) : RecyclerView.ItemDecoration() {
-
-    private val offset = context.resources.getDimensionPixelSize(R.dimen.bottom_navigation_height)
-
-    override fun getItemOffsets(
-        outRect: Rect,
-        view: View,
-        parent: RecyclerView,
-        state: RecyclerView.State
-    ) {
-        val itemPosition = parent.getChildAdapterPosition(view)
-        if (itemPosition == 0) {
-            outRect.top = offset
-        }
-    }
-
-}

app/src/main/java/com/sirekanyan/knigopis/feature/books/BooksView.kt

@@ -7,7 +7,6 @@ import com.sirekanyan.knigopis.common.android.dialog.DialogFactory
 import com.sirekanyan.knigopis.common.android.dialog.createDialogItem
 import com.sirekanyan.knigopis.common.android.header.HeaderItemDecoration
 import com.sirekanyan.knigopis.common.android.header.StickyHeaderImpl
-import com.sirekanyan.knigopis.common.android.recycler.BottomOffsetItemDecoration
 import com.sirekanyan.knigopis.common.android.toast.CommonView
 import com.sirekanyan.knigopis.common.extensions.*
 import com.sirekanyan.knigopis.common.functions.handleError
@@ -48,7 +47,6 @@ class BooksViewImpl(
     init {
         booksRecyclerView.adapter = booksAdapter
         booksRecyclerView.addItemDecoration(HeaderItemDecoration(StickyHeaderImpl(booksAdapter)))
-        booksRecyclerView.addItemDecoration(BottomOffsetItemDecoration(context))
         booksRecyclerView.addOnScrollListener(FabOnScrollListener(resources, addBookButton))
         addBookButton.setOnClickListener { callbacks.onAddBookClicked() }
     }

app/src/main/java/com/sirekanyan/knigopis/feature/notes/NotesView.kt

@@ -1,9 +1,6 @@
 package com.sirekanyan.knigopis.feature.notes
 
 import android.view.View
-import com.sirekanyan.knigopis.common.android.recycler.BottomOffsetItemDecoration
-import com.sirekanyan.knigopis.common.android.recycler.TopOffsetItemDecoration
-import com.sirekanyan.knigopis.common.extensions.context
 import com.sirekanyan.knigopis.common.extensions.hide
 import com.sirekanyan.knigopis.common.extensions.keepOnTop
 import com.sirekanyan.knigopis.common.extensions.show
@@ -37,8 +34,6 @@ class NotesViewImpl(
 
     init {
         notesRecyclerView.adapter = notesAdapter
-        notesRecyclerView.addItemDecoration(TopOffsetItemDecoration(context))
-        notesRecyclerView.addItemDecoration(BottomOffsetItemDecoration(context))
     }
 
     override fun updateNotes(notes: List<NoteModel>) {

app/src/main/java/com/sirekanyan/knigopis/feature/users/UsersView.kt

@@ -4,9 +4,6 @@ import android.view.View
 import com.sirekanyan.knigopis.common.android.dialog.DialogFactory
 import com.sirekanyan.knigopis.common.android.dialog.DialogItem
 import com.sirekanyan.knigopis.common.android.dialog.createDialogItem
-import com.sirekanyan.knigopis.common.android.recycler.BottomOffsetItemDecoration
-import com.sirekanyan.knigopis.common.android.recycler.TopOffsetItemDecoration
-import com.sirekanyan.knigopis.common.extensions.context
 import com.sirekanyan.knigopis.common.extensions.hide
 import com.sirekanyan.knigopis.common.extensions.keepOnTop
 import com.sirekanyan.knigopis.common.extensions.show
@@ -45,8 +42,6 @@ class UsersViewImpl(
 
     init {
         usersRecyclerView.adapter = usersAdapter
-        usersRecyclerView.addItemDecoration(TopOffsetItemDecoration(context))
-        usersRecyclerView.addItemDecoration(BottomOffsetItemDecoration(context))
     }
 
     override fun updateUsers(users: List<UserModel>) {

app/src/main/res/layout/books_page.xml

@@ -14,6 +14,7 @@
         android:layout_height="match_parent"
         android:clipToPadding="false"
         android:paddingTop="0.1dp"
+        android:paddingBottom="56dp"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         tools:listitem="@layout/book" />
 

app/src/main/res/layout/notes_page.xml

@@ -12,7 +12,8 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:clipToPadding="false"
-        android:paddingTop="8dp"
+        android:paddingTop="64dp"
+        android:paddingBottom="56dp"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         tools:listitem="@layout/note" />
 

app/src/main/res/layout/users_page.xml

@@ -12,8 +12,8 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:clipToPadding="false"
-        android:paddingTop="8dp"
-        android:paddingBottom="8dp"
+        android:paddingTop="64dp"
+        android:paddingBottom="64dp"
         app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
         tools:listitem="@layout/user" />